Syntax / Formatting fixes + Make more generic and flexible

[j-russell]

I've cleaned up the formatting on this, and change the syntax to be more in-line with puppet best-practices. I've also tried to make it more flexible to support a wider audience.

Let me know what you think!

Thanks,

• Josh

[grundic]

Hello, Josh! Thanks for contributing - that's just great :) But right now I can't accept your push request - too much work to be done :-/ (on wy work, it's not about your push request :) ) This module was written long ago, but here some things I remember were tricky:

• worknig copy of build agent can take huge space, so we have to be cautious recursively changing permissions/bits. I haven't noticed something like that in your code, but it should be tested
• we use custom module users, which was removed in d69fe07. This module comfigures user, it roles and more important - dot files (.netrc, passwords) and subversion authentification caches. Maybe this fucntionality is not directly related to teamcity, but in our environment we wish to configure some paramaters of teamcity user. If you have any thougths, how this can be done more accurately, I would take your advices with pleasure :)

Keep in touch!

[j-russell]

Thanks, no worries! I'm using this updating version myself and your initial module was a great starting point. I'll put some more thought into how to support both our use cases.

Thanks again!

• Josh