search

grundic / teamcity-web-parameters

Teamcity plugin that provides dynamic parameters for builds from web service
MIT License
44 stars 16 forks source link

Documentation for Key/Value displayed/consumed is inverted #2

Closed westshawn closed 9 years ago

westshawn commented 9 years ago

Thanks for your work on this great plugin!

I noticed one small issue on https://github.com/grundic/teamcity-web-parameters under the "Web-service" section:

Each element in options's array is hash; key will be option's display name, value will be option's value, enabled will determine if option will be enabled.

In practice, it seems like the key/value are inverted: the "value" from the hash is displayed in the select list, and the "key" from the hash is being consumed by TeamCity.

grundic commented 9 years ago

@westshawn, thank you for you time for creating this issue! I've checked it right now -- everything works just like you said, my bad. In order to keep compatibility with already running and configured services, I'd better just swap items in documentation.

grundic commented 9 years ago

Well, and here is the bug itself

grundic commented 9 years ago

@westshawn, the issue is fixed now, you can download version 1.2.0 and check it. Thank you!

westshawn commented 9 years ago

@grundic, Thanks for the lightning-fast fix. It works as expected. Thank You!