search

gruns / furl

🌐 URL parsing and manipulation made easy.
Other
2.6k stars 151 forks source link

[Improvement] Fix code quality issues #133

Closed withshubh closed 3 years ago

withshubh commented 3 years ago

Description

Hi :wave: I ran the DeepSource static analyzer on the forked copy of this repo and found some interesting code quality issues. This PR fixes a few of them.

Summary of changes

withshubh commented 3 years ago

Hi @gruns :wave: Please review this PR! :sparkles:

withshubh commented 3 years ago

@gruns I hope you're doing good.

Please have a look at this PR! :sparkles:

gruns commented 3 years ago

thank you for the PR

do you guys submit these PRs just to get deepsource.toml files in as many repos as possible?

withshubh commented 3 years ago

thank you for the PR

do you guys submit these PRs just to get deepsource.toml files in as many repos as possible?

Haha :smiley: Nope @gruns

We're just helping out Open Source maintainers by helping them integrate and activate DeepSource on their repositories. DeepSource is a code review automation tool that detects code quality issues and helps developers automatically fix some of them. DeepSource can be used to track test coverage, Detect problems in Dockerfiles, etc. in addition to detecting issues in code.

Did you check out the issues that were caught in this repo?

gruns commented 3 years ago

deepsource is proprietary, ie not open source, correct?

withshubh commented 3 years ago

Yes, It is proprietary. Parts of DeepSource are built using Open Source tech So to give back to the community, DeepSource is free for open source forever. :sparkling_heart:

gruns commented 3 years ago

we're not going to integrate proprietary tech into furl unless the boon is worth it. it's not here

also i would encourage you to announce your affiliation with your employer, and its non-open source tech, up front in the future