search

gruns / furl

🌐 URL parsing and manipulation made easy.
Other
2.63k stars 152 forks source link

Use ipaddress to detect valid and invalid IPs #165

Open azmeuk opened 2 years ago

azmeuk commented 2 years ago

Fixes #164

This leads to a breaking change: well-formed but invalid IPv6 such as [0:0:0:0:0:0:0:1:1:1:1:1:1:1:1:9999999999999] now raise a ValueError. However one can argue that this is not exactly a behavior change but more a bugfix.

If you think the breaking change is too harsh, I can do another PR that would raise a deprecation warning when a well-formed invalid IPv6 is encountered, to be merged and released before this PR is merged and released.

What do you think?

azmeuk commented 12 months ago

Hi @gruns Would you have hopefully some time to review this PR and #166 soon? :pray: Thank you