gruns / furl

🌐 URL parsing and manipulation made easy.
Other
2.6k stars 151 forks source link

Removes "git@" from git remote URL #169

Open dev-rinchin opened 1 year ago

dev-rinchin commented 1 year ago

Hi, ClearML uses furl to remove a user from a git remote URL, so furl removes username when the remote URL is like "ssh://git@0.0.0.0:1234/path/to/repo.git" (with "ssh://git@"):

should I use more specific lib/tool to parse git-like URLs?

qxeq commented 6 months ago

To preserve git@, username needs to be set to False.

I believe the second case is the correct behavior, its just that the first example is missing the scheme so that the parser thinks git@0.0.0.0 is the scheme which is obviously incorrect.