Open dev-rinchin opened 1 year ago
To preserve git@
, username
needs to be set to False
.
I believe the second case is the correct behavior, its just that the first example is missing the scheme so that the parser thinks git@0.0.0.0
is the scheme which is obviously incorrect.
Hi, ClearML uses furl to remove a user from a git remote URL, so furl removes username when the remote URL is like "ssh://git@0.0.0.0:1234/path/to/repo.git" (with "ssh://git@"):
Ok:
furl.furl("git@0.0.0.0:1234/path/to/repo.git").remove(username=True, password=True).tostr()
expected: git@0.0.0.0:1234/path/to/repo.git received: git@0.0.0.0:1234/path/to/repo.gitNot as expected:
furl.furl("ssh://git@0.0.0.0:1234/path/to/repo.git").remove(username=True, password=True).tostr()
expected: ssh://git@0.0.0.0:1234/path/to/repo.git received: ssh://0.0.0.0:1234/path/to/repo.gitshould I use more specific lib/tool to parse git-like URLs?