search

gruntjs / grunt-contrib-compass

Compile Compass to CSS.
http://gruntjs.com/
MIT License
626 stars 128 forks source link

feat(autoselect): Finds the first instance of compass and bundle in the ... #235

Closed malys closed 8 years ago

malys commented 9 years ago

Hi, Please could you close this pull request 234.

Now, I use 'which' module to detect the extension of executable. I'm working on Windows ( I'm ashamed ;)) and some tests doesn't work.

   command: 'POSIXLY_CORRECT=1 grunt compass:compile'
    #unix like syntax, It isn't compatible with Windows (SET command: 'POSIXLY_CORRECT=1 grunt compass:compile')

But, my changes works on my platform.

I have decided to remove 

if (process.platform === 'win32') {

and to trust 'which' module. What do you think about this cleaning?

I can't test my changes on Mac OS or Linux. Have you any CI platform to validate them?

sindresorhus commented 9 years ago

Tests are failing: https://travis-ci.org/gruntjs/grunt-contrib-compass/jobs/59198469

malys commented 9 years ago

All is well — The Travis CI build passed :)

shama commented 8 years ago

Merged, thank you!