gruntjs / grunt-contrib-connect

Start a static web server.
http://gruntjs.com
MIT License
714 stars 146 forks source link

Bug: `open.appName` doesn't work in v1.0.2 #229

Closed intih closed 5 years ago

intih commented 7 years ago

open.appName doesn't work - setting it to any value (e.g. 'firefox', 'google chrome', ... on Mac OS) doesn't open the specified browser. This is due to the incorrect parameter being passed to opn, which replaced the open package in v1.0.2.

Background opn was updated from v1.0.0 to opn 4.0.0 in v1.0.2 of connect

opn v1.0.0 allowed a second string parameter to be set - the app to open the target with

opn v^4.0.0, however, only takes 1 optional second parameter. Only 2 values can be set in the config: wait and app.

intih commented 7 years ago

https://github.com/gruntjs/grunt-contrib-connect/pull/227