search

gruntjs / grunt-contrib-connect

Start a static web server.
http://gruntjs.com
MIT License
714 stars 146 forks source link

Replace http2 with node-http2 #251

Closed jacopolanzoni closed 6 years ago

jsf-clabot commented 6 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

Jacopo Lanzoni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

XhmikosR commented 6 years ago

@jacopolanzoni: please sign the CLA otherwise I can't merge any of your patches. But it'd be faster for me at this point to just merge my branch :P

XhmikosR commented 6 years ago

Thanks for the contributions, but I'll go with my branch for now because it's faster and it's green.

jacopolanzoni commented 6 years ago

I did sign it, I am not sure what I am doing wrong...

untitled

XhmikosR commented 6 years ago

Your git user details are not the same I guess. See the CLA bot's comment.

jacopolanzoni commented 6 years ago

Thanks for your comment, but your behaviour does not seem to me very collaborative. I am grateful for the hints you are giving me, but closing my PRs and opening one with the same changes is not a fair behaviour in the open-source community.

XhmikosR commented 6 years ago

I didn't open a PR, I just decided to fix it myself, well because it was a lot faster. You made 4 PRs for this.