search

gruntjs / grunt-contrib-connect

Start a static web server.
http://gruntjs.com
MIT License
714 stars 146 forks source link

`node-http2` is deprecated. Use node's built in `http2` #270

Closed darcyparker closed 3 months ago

darcyparker commented 3 years ago

https://www.npmjs.com/package/node-http2 points to https://github.com/kaazing/node-http2 which no long exists.

It originally forked https://github.com/molnarg/node-http2, which notes that as of Node v9, the built in http2 can be used.

darcyparker commented 3 years ago

Looks like this is a duplicate of https://github.com/gruntjs/grunt-contrib-connect/issues/268, but it is not obvious by the title.

pedrosanta commented 3 years ago

Looks like this is a duplicate of #268, but it is not obvious by the title.

Yhea @darcyparker, the issue started as the vulnerability report and then shifted focus. This line of action is more succinct. I'll close that one and let's join efforts on this one.

Checking #268 for context about the vulnerability and possible lines of action is still worthwhile, namely my comment here: https://github.com/gruntjs/grunt-contrib-connect/issues/268#issuecomment-903302596

pedrosanta commented 3 years ago

Also, as I state on my comment (https://github.com/gruntjs/grunt-contrib-connect/issues/268#issuecomment-903302596) updating to node http2 requires a new major version (it's a breaking change on the engine supported versions).

pedrosanta commented 1 year ago

@Krinkle Hello, with the 4.0.0 release and the Node engines/version update (>=16), maybe we can consider, revisit this?

Krinkle commented 1 year ago

@pedrosanta Yes! I don't use the http2 feature myself, but I'd be open to reviewing a pull request if you've got something in mind.

pedrosanta commented 1 year ago

Sure, will post one then, whenever I can. Cheers.