search

gruntjs / grunt-contrib-jasmine

Run jasmine specs headlessly through Headless Chrome
http://gruntjs.com/
MIT License
354 stars 197 forks source link

bump puppeteer to 8.0.0 #332

Closed fred104 closed 3 years ago

fred104 commented 3 years ago

Recently we encountered an error from Chromium after upgrading Mac to 11.3.1. This issue can be resolved after upgrading to newer puppeteer which will use new version of Chromium.

Error caught from Headless Chrome. More info can be found by opening the Spec Runner in a browser.
>> Error: Page crashed!
>>   at Page._onTargetCrashed (/Users/fred/project/node_modules/puppeteer/lib/Page.js:215:24)
>>   at CDPSession.<anonymous> (/Users/fred/project/node_modules/puppeteer/lib/Page.js:123:56)
>>   at CDPSession.emit (events.js:315:20)
>>   at CDPSession._onMessage (/Users/fred/project/node_modules/puppeteer/lib/Connection.js:200:12)
>>   at Connection._onMessage (/Users/fred/project/node_modules/puppeteer/lib/Connection.js:112:17)
>>   at WebSocket.<anonymous> (/Users/fred/project/node_modules/puppeteer/lib/WebSocketTransport.js:44:24)
>>   at WebSocket.onMessage (/Users/fred/project/node_modules/ws/lib/event-target.js:120:16)
>>   at WebSocket.emit (events.js:315:20)
>>   at Receiver.receiverOnMessage (/Users/fred/project/node_modules/ws/lib/websocket.js:789:20)
>>   at Receiver.emit (events.js:315:20)
>>   at Receiver.dataMessage (/Users/fred/project/node_modules/ws/lib/receiver.js:422:14)
>>   at Receiver.getData (/Users/fred/project/node_modules/ws/lib/receiver.js:352:17)
>>   at Receiver.startLoop (/Users/fred/project/node_modules/ws/lib/receiver.js:138:22)
>>   at Receiver._write (/Users/fred/project/node_modules/ws/lib/receiver.js:74:10)
>>   at doWrite (_stream_writable.js:403:12)
>>   at writeOrBuffer (_stream_writable.js:387:5)
>>   at Receiver.Writable.write (_stream_writable.js:318:11)
>>   at Socket.socketOnData (/Users/fred/project/node_modules/ws/lib/websocket.js:864:35)
>>   at Socket.emit (events.js:315:20)
>>   at addChunk (_stream_readable.js:295:12)
>>   at readableAddChunk (_stream_readable.js:271:9)
>>   at Socket.Readable.push (_stream_readable.js:212:10)
>>   at TCP.onStreamRead (internal/stream_base_commons.js:186:23)
fred104 commented 3 years ago

It seems to me that we probably need to drop node 8 support.

fred104 commented 3 years ago

@vladikoff What do you think?

fred104 commented 3 years ago

@steveoh @vladikoff Would you mind reviewing this PR?

vladikoff commented 3 years ago

@fred104 hey yeah, thanks for the PR! 👍 we need to move to github actions soon for this

fred104 commented 3 years ago

@vladikoff Do you happen to know when to publish this to npm repository?

vladikoff commented 3 years ago

later today probably

On Wed, May 12, 2021 at 9:10 AM Fred @.***> wrote:

@vladikoff https://github.com/vladikoff Do you happen to know when to publish this to npm repository?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/gruntjs/grunt-contrib-jasmine/pull/332#issuecomment-839760022, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAA7N47PQISBPL5RKSVNXATTNJ45BANCNFSM44QYAKFQ .

fred104 commented 3 years ago

Got it. Thanks!