search

gruntjs / grunt-contrib-jst

Compile underscore templates to JST file.
http://gruntjs.com/
MIT License
113 stars 45 forks source link

Fixes issue where setting the "namespace" to FALSE breaks the build #57

Closed SimonChong closed 10 years ago

SimonChong commented 10 years ago

This fixes gruntjs/grunt-contrib-jst#56

Also added a feature that enables adding of an optional banner and / or footer

sindresorhus commented 10 years ago

Also added a feature that enables adding of an optional banner and / or footer

That should have been a separate pull request. But we don't want this anyways as you should rather use a separate grunt task for this, like grunt-header.

Happy to receive a PR with just the fix though.

SimonChong commented 10 years ago

Your response is disappointing because grunt-contrib-cssmin (which you also maintain has this functionality). Not to mention grunt-contrib-uglify , grunt-contrib-less , grunt-contrib-concat , and others.

I actually used the code from the other repos mentioned (which is probably code you wrote or already reviewed).

If I should use grunt-header wouldn't it be logical for you to strip this functionality out of the other grunt-contrib plugins I mentioned?

moraleslevi commented 9 years ago

According the the documentation this should work, but does not. Not sure why this PR was closed. Is this actively maintained anymore?