Fixed Lodash security issue

shailesh-kanzariya commented 3 years ago

What issue this PR fixes?

When running npm audit, grunt-contrib-jst reports HIGH security vulnerability issues through its lodash dependency

How this issue is fixed in this PR?

Upgraded lodash version to latest v4.17.20
Latest lodash(v4.17.20) version has breaking change in its _.template() definition from its _.template() in lodash(v2.4.2) version which was breaking existing functionalities and all test cases. So modified _.template() call to match the latest definition.
In latest lodash version, _.template() does not return __e = _.escape; so all test cases were failing. Modified all test cases by removing __e = _.escape; in its expected version as __e = _.escape; was un used.
Also observed that all test cases calls use expect in place of actual parameters in test.equal() call so fixed this issue

vladikoff commented 3 years ago

I think you also need to modify the CI Scripts

shailesh-kanzariya commented 3 years ago

I think you also need to modify the CI Scripts

Modified CI Scripts

gruntjs / grunt-contrib-jst