search

gruntjs / grunt-contrib-nodeunit

Run Nodeunit unit tests.
http://gruntjs.com/
MIT License
70 stars 27 forks source link

v1.0.0 #44

Closed vladikoff closed 8 years ago

XhmikosR commented 8 years ago

Hmm, the CI error is a new one @vladikoff

vladikoff commented 8 years ago

yeah I know, I'm investigating the issue atm

XhmikosR commented 8 years ago

I still believe you shouldn't do it like that. Better have clean patches.

vladikoff commented 8 years ago

Sure!

XhmikosR commented 8 years ago

I mean, if I go to the git log I will see v1.0.0 but that doesn't reflect the changes you made :)

XhmikosR commented 8 years ago

Also, @shama, I'm still waiting for the guidelines and the internal new version in order to backport the changes to the contrib plugins.

vladikoff commented 8 years ago

@XhmikosR link?

XhmikosR commented 8 years ago

@vladikoff: https://github.com/gruntjs/grunt-contrib-nodeunit/pull/44/commits

This PR should be 2 separate patches IMO. One with the fixes and one with the version bump.

vladikoff commented 8 years ago

@XhmikosR I meant do you have a link to discuss the guidelines for :

Also, @shama, I'm still waiting for the guidelines and the internal new version in order to backport the changes to the contrib plugins.

XhmikosR commented 8 years ago

Oh, sorry, it was in a previous PR we had. We need to gather all this in an issue or something so that we are all in sync.