search

gruntjs / grunt-contrib-nodeunit

Run Nodeunit unit tests.
http://gruntjs.com/
MIT License
70 stars 27 forks source link

Proposed solution for #8 #9

Closed phun-ky closed 11 years ago

phun-ky commented 11 years ago

Adding proposal to solve #8, updated done method:

// Executed when everything is all done.
done: function (assertions) {
  (...)
  } else if (assertions.length === 0) {
    if(files.length > 0){
      grunt.warn('0/0 assertions ran (' + assertions.duration + 'ms)');
    } else {
      grunt.log.ok('No test files found, so no assertions was run.');
    }
  } 
  (...)
}
phun-ky commented 11 years ago

Can I get a status on this?

phun-ky commented 11 years ago

Sorry if I nag to much, but what's the status on this?

shama commented 11 years ago

Sorry to close this after us being unresponsive for so long. I think if there are no tests then it should fail as that is a mistake. At least that behavior is similar to the other grunt plugins. Sorry and thanks anyways Alexander!