search

gruntjs / grunt-contrib-pug

Compile Pug templates.
http://gruntjs.com/
MIT License
328 stars 77 forks source link

Grunt Plugin Renaming jade -> pug #156

Closed vladikoff closed 8 years ago

vladikoff commented 8 years ago

@shinnn @XhmikosR @shama do we need to rename this plugin or something to work with https://github.com/pugjs/jade/issues/2184 ?

shinnn commented 8 years ago

Um, as the Jade maintainer said, really unfortunate...

Yes we need to rename this plugin to grunt-contrib-pug in the future, but I think it's better to wait until current Jade repo (https://github.com/pugjs/jade) is renamed.

vladikoff commented 8 years ago

cool thanks!

XhmikosR commented 8 years ago

Yeah, I totally agree with @shinnn :+1:

XhmikosR commented 8 years ago

@vladikoff @shama: so how do we proceed with this? Jade has already been renamed to Pug.

shama commented 8 years ago

I've got a new repo started for the rename: https://github.com/gruntjs/grunt-contrib-pug Once that one is ready, we can publish a new version deprecating this repo and let people know it has been renamed.

XhmikosR commented 8 years ago

Why don't we just rename everything and the repo? Something similar to what Jade did.

And for npm there must be a way to show a message.

shama commented 8 years ago

@XhmikosR Sure we could just rename this repo instead. I think we'll still have to deprecate grunt-contrib-jade though as afaik, npm doesnt have a way to rename a package. Just deprecate the old with a message that says it's renamed.

XhmikosR commented 8 years ago

It should be possible to show a message for npm but I haven't done it myself.

So for the repo, create a branch here, rename everything, make a PR to verify, merge the PR, then rename the repo. And finally take care of npm.

shama commented 8 years ago

Cool. Thanks @XhmikosR! I think it's ok to just push directly to master. I've started on the rename here: b731379a3a706e4de2c8bd5d1e45ade731bcef97

XhmikosR commented 8 years ago

OK, so I see 72 hits in 8 files without CHANGELOG, which we shouldn't change.

XhmikosR commented 8 years ago

@shama: I verified everything is OK now in master.

SO only the npm package is left.

shama commented 8 years ago

@XhmikosR Rad thank you! Should we publish as grunt-contrib-pug@1.0.0?

@shinnn Thanks for adding us to that package!

willsteinmetz commented 8 years ago

So when is the new version being pushed out to NPM? It's currently still the old 0.0.0 version that doesn't seem to work correctly.

shama commented 8 years ago

@willsteinmetz Sorry my mistake. It looks like I forgot to publish. Thanks for the ping.

willsteinmetz commented 8 years ago

@shama No problem. Thanks for updating it! :D