search

gruntjs / grunt-contrib-requirejs

Optimize RequireJS projects using r.js.
http://gruntjs.com/
MIT License
504 stars 105 forks source link

Issues with nested requirejs configs #55

Closed binarykitchen closed 10 years ago

binarykitchen commented 10 years ago

In this issue https://github.com/thomaswelton/requirejs-google-analytics/issues/7 I have documented that there are nested requirejs configs and this is messing up with grunt-contrib-requirejs.

In https://github.com/thomaswelton/requirejs-google-analytics/blob/master/dist/GoogleAnalytics.js#L14 you see a path and shim definition. If I copy that into my grunt file then it works. But IMO this is code duplication and not good.

Please read the above issue for details. Any advice / feedback is very welcome.

Thanks!

tkellen commented 10 years ago

I'm watching the linked issue to see what comes of it. Can you confirm if this problem persists when you use the r.js optimizer directly? Assuming it does (I expect it will), the issue is not with this plugin.

binarykitchen commented 10 years ago

I haven't tried using r.js directly. It happens with this plugin. That's all I can say.

binarykitchen commented 10 years ago

Alright, have posted this on https://github.com/jrburke/r.js/issues/596 too ...

jamesplease commented 10 years ago

Closing this due to the outcome of the discussion on jrburke/r.js#596. If things change over there and you're still having issues with grunt-contrib-requirejs just make a comment here and we can revisit the issue.