search

gruntjs / grunt-contrib-sass

Compile Sass to CSS.
http://gruntjs.com/
MIT License
848 stars 141 forks source link

Support for Dart-Sass #239

Open vikmn opened 7 years ago

vikmn commented 7 years ago

The readme mentions the requirement of ruby and sass for the purpose of this task. However it appears that the newer version of Sass is being moved away from ruby and uses dart. Also the newer version is available as an npm package @ github.com/sass/dart-sass. Will this task work out of the box without ruby if the new package was to be used?

nex3 commented 6 years ago

Dart Sass is in Release Candidate phase now, with a full release probably coming next week. I'd be happy to send a pull request to add support for it if a maintainer can help me land it.

laurenhamel commented 6 years ago

Checking in to see if there's any update on this issue since the 1.5.0 release of Dart Sass. I'm currently using the latest release of grunt-contrib-sass with latest dart-sass. So far, I've encountered some errors with compiling .scss files and ran into issues with the grunt-contrib-sass options versus the dart-sass cli (i.e., --[no-]source-map instead of --sourcemap, --style only accepts compressed or expanded, no --cache option, etc.). An update to this package would be helpful since the Ruby Sass version has been deprecated.

laurenhamel commented 6 years ago

I submitted a PR for a proposed upgrade to using Dart Sass. I left the integration tools (travis/appveyor) intact since you guys will likely need to review that stuff based on the proposed changes I'm suggesting. In the meantime, I've also created grunt-dart-sass, which uses the Dart Sass JavaScript API, for anyone who may land here looking for the same thing I was.

ve3 commented 5 years ago

@laurenhamel It seems that this has not been merged? https://github.com/gruntjs/grunt-contrib-sass/pull/244

laurenhamel commented 5 years ago

@ve3, no, it was not. The PR I submitted (#244) was closed without review because of "too many changes," and it seems that this project is moving in the direction of an implementation-agnostic grunt task. If you're looking for a an immediate solution using Dart Sass, refer to my previous comment.