search

gruntjs / grunt-contrib-uglify

Minify files with UglifyJS.
http://gruntjs.com/
MIT License
1.48k stars 347 forks source link

v4.0.1. #535

Closed alexlamsl closed 5 years ago

alexlamsl commented 5 years ago

@XhmikosR PTAL

XhmikosR commented 5 years ago

BTW, I removed you many months ago from the npm users from grunt-contrib-uglify, because you hadn't enabled 2FA. If you have enabled it, let me know and I will add you back.

alexlamsl commented 5 years ago

I have 2FA for npm working now I think, i.e. every time I do npm login or npm publish I get prompted for "OTP token".

XhmikosR commented 5 years ago

@alexlamsl can you rebase this and make sure package-lock.json doesn't have any unneeded stuff?

I added you back to npm BTW.

alexlamsl commented 5 years ago

Sorry for the delay - was in a call just now.

I've made sure package-lock.json only contains version string change.

XhmikosR commented 5 years ago

Let's wait for CI and then merge. Then create the GH release, which creates the tag and then npm publish.

alexlamsl commented 5 years ago

@XhmikosR heh, you beat me to tag and publish by mere seconds 👻

XhmikosR commented 5 years ago

haha, I wasn't sure if you were going to do it yourself :P

alexlamsl commented 5 years ago

AppVeyor build on master got stuck in the queue, so I was anxiously waiting for it to pass.

Thanks for the help! 👍