gruntjs / grunt-contrib-uglify

Minify files with UglifyJS.
http://gruntjs.com/
MIT License
1.48k stars 347 forks source link

Issue with grunt as dev dependency #559

Closed hemachandsai closed 3 years ago

hemachandsai commented 3 years ago

Shouldn't grunt be a direct dependency in this plugin turning grunt into a peer dependency for projects installing this plugin?

XhmikosR commented 3 years ago

Nope, that's exactly the opposite of how peer dependencies work.

hemachandsai commented 3 years ago

Thanks for the reply, is is that grunt is a peer dependency for the project but peer dependency installation is handled by npm and we need not add it as direct dependency. If it was any other package related to functionality it should have been included as direct dependency right? because of the fact that grunt is only required during the package build time and not during the server runtime.