search

gruntjs / grunt-contrib-watch

Run tasks whenever watched files change.
http://gruntjs.com/
MIT License
1.98k stars 356 forks source link

tests are failing against nodejs 6.9.1 #528

Closed pnemade closed 6 years ago

pnemade commented 7 years ago

In Fedora 25 , we have nodejs-6.9.1 against which if we build this grunt-contrib-watch module then it failed for 3 tests. 1) fail_test.js due to warning

Testing fail_test.js
fail - warn...Running "watch:warn" (watch) task
Waiting...
>> File "lib/one.js" changed.

Running "warn" task
Warning: This task should warn!

Running "watch:warn" (watch) task
Waiting...
>> File "lib/one.js" changed.

Running "warn" task
Warning: This task should warn!

Running "watch:warn" (watch) task
Waiting...

OK
<....snip...>
Warning: 2/43 assertions failed (56616ms)^G Use --force to continue.

2) livereload_test.js due to assertion error 

livereload - livereloadOnErrorTrue...Initializing
Command-line options: --verbose
Reading "Gruntfile.js" Gruntfile...OK
Registering Gruntfile tasks.
Initializing config...OK
Registering "../../../tasks" tasks.
Loading "watch.js" tasks...OK
+ watch
Loading "Gruntfile.js" tasks...OK
+ before, iamerror, writecss
Running tasks: watch:livereloadOnErrorTrue
Running "watch:livereloadOnErrorTrue" (watch) task
Waiting...
Verifying property watch exists in config...OK
Verifying property watch.livereloadOnErrorTrue.files exists in config...OK
Live reload server started on port: 35729
Watching lib/one.js for changes.
Watching lib/two.js for changes.
>> File "lib/one.js" changed.
Initializing
Command-line options: --verbose
Reading "Gruntfile.js" Gruntfile...OK
Registering Gruntfile tasks.
Initializing config...OK
Registering "../../../tasks" tasks.
Loading "watch.js" tasks...OK
+ watch
Loading "Gruntfile.js" tasks...OK
+ before, iamerror, writecss
Running tasks: iamerror
Running "iamerror" task
Warning: I am an error/warning Use --force to continue.
Aborted due to warnings.
Live reloading lib/one.js...
Completed in 0.377s at Wed Dec 07 2016 07:47:51 GMT+0000 (UTC) - Waiting...
OK
livereload - livereloadOnErrorFalse...Initializing
Command-line options: --verbose
Reading "Gruntfile.js" Gruntfile...OK
Registering Gruntfile tasks.
Initializing config...OK
Registering "../../../tasks" tasks.
Loading "watch.js" tasks...OK
+ watch
Loading "Gruntfile.js" tasks...OK
+ before, iamerror, writecss
Running tasks: watch:livereloadOnErrorFalse
Running "watch:livereloadOnErrorFalse" (watch) task
Waiting...
Verifying property watch exists in config...OK
Verifying property watch.livereloadOnErrorFalse.files exists in config...OK
Live reload server started on port: 35729
Watching lib/one.js for changes.
Watching lib/two.js for changes.
>> File "lib/one.js" changed.
Initializing
Command-line options: --verbose
Reading "Gruntfile.js" Gruntfile...OK
Registering Gruntfile tasks.
Initializing config...OK
Registering "../../../tasks" tasks.
Loading "watch.js" tasks...OK
+ watch
Loading "Gruntfile.js" tasks...OK
+ before, iamerror, writecss
Running tasks: iamerror
Running "iamerror" task
Warning: I am an error/warning Use --force to continue.
Aborted due to warnings.
Completed in 0.402s at Wed Dec 07 2016 07:47:53 GMT+0000 (UTC) - Waiting...
OK

2) nospawn_test.js at

Testing nospawn_test.js
nospawn - nospawn...Running "server" task
Server is listening...
Running "watch" task
Waiting...
>> File "lib/nospawn.js" changed.
Running "server" task
Server is talking!
Running "watch" task
Completed in 0.111s at Wed Dec 07 2016 08:01:49 GMT+0000 (UTC) - Waiting...
OK
nospawn - interrupt
...............<test case stop working>...............

Please ask if needed anymore input/log on this issue.

pnemade commented 7 years ago

If we use grunt nodeunit -v --force then fail_test.js and livereload_test.js succeeds.

shama commented 6 years ago

Not sure, test are passing for me.