Closed gamtiq closed 10 years ago
Thanks for the PR @gamtiq! Give us some time to test and give feedback.
Hey @gamtiq sorry for the slow response. Just tested this and this seems cool. One thing, would it be better to have init.runNpmInstall(props.npm_install);
and leave the done
to the template? runNpmInstall
might not be the final step in the scaffolding.
Let me know if you wanna update this and I will reopen.
Hello @vladikoff,
Do you mean that:
runNpmInstall
should have the following signature: init.runNpmInstall(required, done)
where both parameters are optional?required
parameter should not have true
as default value?
If so, I can change the implementation.Yea so we should be able to use init.runNpmInstall()
and that would by default run npm install.
And also use it this way:
init.runNpmInstall(props.npm_install)
somethingElse()
done()
I have made the change. Now it is possible to use runNpmInstall
as you wrote:
init.runNpmInstall(props.npm_install)
somethingElse()
done()
Or by this way:
init.runNpmInstall(props.npm_install, function() {
// The following code will be run in any case but after finishing of "npm install" if props.npm_install is true
somethingElse();
done();
});
Thanks! :dart:
Hello,
I have added:
keywords
andnpm_install
prompt.sanitizeYesNo
to convertyes/no
answers into boolean valuesinit.runNpmInstall
to runnpm install
commandgithub_user
key indefaults.json