search

gruntjs / grunt-lib-phantomjs

Grunt and PhantomJS, sitting in a tree.
http://gruntjs.com/
MIT License
93 stars 63 forks source link

Upgrade to Phantom2 #74

Closed naugtur closed 9 years ago

naugtur commented 9 years ago

Are you considering an upgrade? How important is it for you?

brodrigu commented 9 years ago

:+1:

dwelle commented 9 years ago

+1

lukeapage commented 9 years ago

given the regressions (http://phantomjs.org/release-2.0.html), it would make sense to wait for a 2.1 (or 2.0.1) release with those issues fixed...

moriakaice commented 9 years ago

Two months later, has anything changed in the topic?

fishermand46 commented 9 years ago

:+1: A huge issue was fixed in Phantom 2.0. Would be nice to see it upgraded here.

nathancahill commented 9 years ago

Also interested in upgrading to Phantom 2.0 :+1:

mgol commented 9 years ago

package.json still depends on Phantom older than 2, seems that this bug shouldn't be closed yet?

nathancahill commented 9 years ago

There's a summary of reasons to hold off on 2.0 for now: travis-ci/travis-ci/issues/3225

At some point, 2.0.1 will be released (ariya/phantomjs/issues/12902) which should fix a number of regressions. Regardless, CoffeeScript is no longer supported, so switching to PhantomJS 2.0.x should be a major version increment.

Any thoughts on supporting both versions? As a side note, here's the changes that need to be made to switch: 84001a5. It uses the unofficial phantomjs2 package on npm.

amoilanen commented 8 years ago

If you want to use PhantomJS 2.0 you can try using the unofficial fork https://www.npmjs.com/package/grunt-lib-phantomjs2-unofficial, it works quite OK with grunt-contrib-jasmine in Windows, not sure about the all possible scenarios, NPM package grunt-lib-phantomjs2-unofficial

Arkni commented 8 years ago

@nathancahill phantomjs v2.1.1 was released and is available for download, see: