search

gruntjs / grunt-lib-phantomjs

Grunt and PhantomJS, sitting in a tree.
http://gruntjs.com/
MIT License
93 stars 63 forks source link

Fix: After killing phantom error (fixes #82 , fixes #78) #83

Closed gyandeeps closed 9 years ago

gyandeeps commented 9 years ago

@shama @sindresorhus @vladikoff Please review as this fix is needed for good. Thanks

gyandeeps commented 9 years ago

CC @jzaefferer @cowboy @jsoverson

gyandeeps commented 9 years ago

@vladikoff Need your help here plz

vladikoff commented 9 years ago

@gyandeeps what help do you need?

gyandeeps commented 9 years ago

Feedback or if its good then a merge and release. So that jasmine and qunit can actually utilize this functionality. As right now both our at ^0.6.0 version which doesn't kill the phantom so everytime you run it spins off a new phatomjs.

vladikoff commented 9 years ago

Code null is a bit strange from spawn, but could be some node issue

gyandeeps commented 9 years ago

I had the same thought. Thanks for this and I will send a PR to update the version on grunt-contrib-jasmine for version update. As these changes were reverted because of this issue.

Thanks a lot.

vladikoff commented 9 years ago

@gyandeeps yeah no problem :smile: , I published 0.7.1 on npm

gyandeeps commented 9 years ago

Awesome. Thanks for help again. :+1: