search

gruntjs / gruntjs.com

Grunt's Website
https://gruntjs.com
Other
155 stars 83 forks source link

Added pagination at the end of the plugin table #190

Closed borracciaBlu closed 6 years ago

borracciaBlu commented 7 years ago

Added pagination at the end of the plugin table.

borracciaBlu commented 7 years ago

Can someone retry the build on Travis? It failed in downloading the plugins...

XhmikosR commented 7 years ago

I restarted Travis, let's see.

XhmikosR commented 7 years ago

Rebased and cleaned it up. After looking at this, I fail to see how it's an improvement compared to the current solution.

/CC @vladikoff for the final choice.

XhmikosR commented 7 years ago

Nevermind, I missed the obvious that we didn't have pagination at the bottom.

Isn't there any other way to achieve the same without changing the ads placement?

XhmikosR commented 7 years ago

OK, changed the patch so that it only adds the pagination at the bottom.

Waiting for @vladikoff.

vladikoff commented 7 years ago

this shifts the pagination on top of the search in the main view for me:

does that do that for you?

XhmikosR commented 7 years ago

Yeah. I guess that is why @borracciaBlu had moved the advertisement below .brand .logo. I restored his original patch if you want to check that out too.

borracciaBlu commented 6 years ago

sorry for the super long delay in answering ...

so @XhmikosR the reason why this PR is because I found myself wishing for a pagination bar at the bottom when i was searching for a plugin.

I usually work with a laptop; the screen is small and i have to scroll on top all the time to change page and this was frustrating me.

Thus I thought a PR was better then a complain.

Of course this is opinionated. So, if you think that a pagination at the button of the page is useless no big deal, no worries :)

Sorry again for the looong delay...