search

gruntjs / gruntjs.com

Grunt's Website
https://gruntjs.com
Other
155 stars 83 forks source link

Headings/anchor style on Documentation are broken #206

Closed pedrosanta closed 3 years ago

pedrosanta commented 4 years ago

Hello,

I've noticed that on the Grunt Documentation the style of the headings/anchors is broken, and I think I know why, but not sure why it's wrong on live site. (Possibly outdated? Different dependency versions?)

This is how it looks on the live site:

Screenshot 2019-10-01 at 10 51 39

But, when I clone this repo and build it locally the headings/anchors are correct:

Screenshot 2019-10-01 at 10 53 08

Now, if you look closely between these two, on the live site the heading text is placed inside the <a> tag, which by per .anchor class style has a font-family: icomoon!important;, hence the wrong serif font style on live site.

<h2>
  <a class="anchor" href="#installing-the-cli" name="installing-the-cli">
    Installing the CLI
  </a>
</h2>

But on my local repo, the heading text is placed outside the <a> tag, which makes it pick up the correct styling, with Lato font.

<h2>
  <a class="anchor" href="#installing-the-cli" id="installing-the-cli"></a>
  Installing the CLI
</h2>

I've already peeked into the code and history to confirm if the deployed version on live site is outdated, or if there could be differences between the versions of the marked dependency used, etc, but to no avail.

Could any of the maintainers take a look to this?

pedrosanta commented 4 years ago

@XhmikosR any thoughts/comment on this? Perhaps triggering a re-deploy of the site to see if might fix it, idk?

XhmikosR commented 4 years ago

@vladikoff please release a new tag to see if it fixes the issue

XhmikosR commented 4 years ago

BTW it works fine for me here. Could either be a caching issue or a Cloudflare issue and someone needs to purge the cache there.

pedrosanta commented 4 years ago

Just throwing the bump here that this is still happening... 😅

pedrosanta commented 4 years ago

@XhmikosR @vladikoff any ideas/comments on this one? 🙂

XhmikosR commented 4 years ago

I'm unsure how to proceed with this, sorry.

pedrosanta commented 4 years ago

Ok @XhmikosR , like, I appreciate your honesty. 😄 Fair game—I'm also a bit confused by it. I have a sense that might be some dependency discrepancy, but not sure.

Was it interesting to like, share the package-lock.json of the live site environment, to see if we could replicate the issue on a local setting? 🤔

pedrosanta commented 3 years ago

Hey @XhmikosR looks like this issue is fixed now on https://gruntjs.com/getting-started.

Pack up bois, our work here is done. 🍻

vladikoff commented 3 years ago

woo we did it!