search

gruntjs / gruntjs.com

Grunt's Website
https://gruntjs.com
Other
155 stars 83 forks source link

Grunt site-0.4.0 list of issues #25

Closed isaacdurazo closed 11 years ago

isaacdurazo commented 11 years ago

@vladikoff I need some help from you :dancers:

  1. [x] We need a CSS class for contrib plugins so I can add the ribbon with the star
  2. [x] We need to activate the "active" CSS class for the side nav menu
  3. [x] Dropdown menu on Plugins side nav is not working
isaacdurazo commented 11 years ago

cc @cowboy

vladikoff commented 11 years ago

Thanks for submitting this, I shall update you when I add this. Probably this weekend...

cowboy commented 11 years ago

Looking great! Here are a few comments, in no particular order:

general

  1. [x] urls should not end in / eg http://stage.gruntjs.com/plugins <- no trailing /
  2. [x] all main nav/footer links (except for plugins) should link to the 1st listed page in the wiki homepage as the landing page for that section

docs

  1. [x] as isaac said, nav items need some kind of "active" class
  2. [x] [[ ]] style links aren't being parsed
  3. [x] all docs paths should be at root level. eg /getting-started not /docs/getting-started
  4. [x] the "Getting started" page should be the home page for docs, there shouldn't be a /docs page

api

  1. [x] urls and H1 should be the full section name, eg. "grunt.config" and http://stage.gruntjs.com/api/grunt.config
  2. [x] there is no /api page, the default page when the "api" nav item is clicked should be http://stage.gruntjs.com/api/grunt (/api can 301 to /api/grunt)

plugins

  1. [x] search seems to be broken
  2. [x] search should be in the left nav, not the top of the plugins list
  3. [x] contrib plugins aren't styled specially
  4. [x] obviously, search filters don't work
  5. [x] search needs a (checked by default) "Show contrib plugins first"
  6. [ ] the package.json devDependencies.grunt property should be shown as "grunt version" for each plugin

community

  1. [x] doesn't seem to be getting pulled from the wiki home page https://github.com/gruntjs/grunt/wiki
sindresorhus commented 11 years ago

Some additions:

vladikoff commented 11 years ago

Hey @isaacdurazo I've added 'active' classes to the main nav and side navs. Feel free to adjust the templates to your needs.

isaacdurazo commented 11 years ago

Thanks @vladikoff!

Also, can you mark the issues you've solved? I marked a few but not sure about most of them :rabbit:

shama commented 11 years ago

Here is a useful GH markdown tip @ctalkington showed me that I think could help here. You can create tasks lists which can be later checked off:

- [ ] Not yet completed
- [ ] Completed

Which then appears as:

Even will show up in the issue tracker with stats about tasks completed. Here is the blog post: https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

cowboy commented 11 years ago

HOLY CRAP

isaacdurazo commented 11 years ago

WOW @shama that is super cool! Thanks!

shama commented 11 years ago

My exact reaction when @ctalkington showed me :D

sindresorhus commented 11 years ago

https://github.com/blog/1375-task-lists-in-gfm-issues-pulls-comments

cowboy commented 11 years ago

A few more visual things:

vladikoff commented 11 years ago

@isaacdurazo, added anchors for docs, such as this: http://stage.gruntjs.com/api/grunt#a-very-important-note @cowboy wants a hover style for anchors (example https://gist.github.com/cowboy/6930b3075e8320fe6088 hover on the headers). I'm sure we can find an icon from the icon app or add our own.

cowboy commented 11 years ago

@sindresorhus can you implement the outstanding plugins page functionality? We want to wrap everything up by EOD Wednesday, and @vladikoff just doesn't have the time to do it all. LMK, thanks!

sindresorhus commented 11 years ago

Yes

vladikoff commented 11 years ago

hey @sindresorhus , Ben and I were talking about a way of 'starring' contrib plugins, does it make sense to match on github.com/gruntjs/* for now? Maybe adjust the heroku app to do that? Just a thought. @isaacdurazo also made some changes to the old template that we had on the plugins page. Due to those changes the search doesn't work, I think it's just a selector issue.

cowboy commented 11 years ago

Will this repo include the heroku app? That way we can have it all hosted in one place.

sindresorhus commented 11 years ago

You currently don't get the GitHub star/forks in the server code. I don't have the time to do this. Could ask @manuel-woelker if he would like to.

@isaacdurazo

@cowboy can you clarify this?

search needs a (checked by default) "Show contrib plugins first"

Is there any point in having this? I don't see the use. We currently have a toggle buttons, that toggles between All Plugins and Contrib Plugins, and the search will search all.

cowboy commented 11 years ago

No matter what the search, I want to always show matching contrib plugins first. Because they're awesome. But unchecking the box will make them sort normally.

cowboy commented 11 years ago

@sindresorhus The current plugins list is getting a few false positives for "Contrib Plugins"

sindresorhus commented 11 years ago

There is currently 7 external plugins using the contrib namespace. I've opened an issue on all of them. I've also updated the site to filter them out.

cowboy commented 11 years ago

@isaacdurazo the body text line height seems too large. Can we reduce it to something like 1.6em?

cowboy commented 11 years ago

@vladikoff the "Migration Guides" section of "Documentation" and "Other" section of "API" aren't showing up in the left nav (per https://github.com/gruntjs/grunt/wiki)

These navs are generated dynamically by parsing the wiki homepage, right?

vladikoff commented 11 years ago

A few todos:

Plugins list todos:

vladikoff commented 11 years ago

CSS Issues:

cowboy commented 11 years ago

Additional CSS / design / image issues:

cowboy commented 11 years ago

@vladikoff how can I get the plugins list to appear on http://localhost:5678/ ?

cowboy commented 11 years ago

Creating a new post-launch issue.