gruntwork-io / boilerplate

A tool for generating files and folders ("boilerplate") from a set of templates
https://www.gruntwork.io
Mozilla Public License 2.0
157 stars 12 forks source link

Boilerplate windows support #164

Closed denis256 closed 3 months ago

denis256 commented 3 months ago

Description

Included changes:

Before this change:

Screenshot 2024-03-04 at 20 48 49

With the change from this PR:

Screenshot 2024-03-04 at 20 46 25

TODOs

Read the Gruntwork contribution guidelines.

Release Notes (draft)

Added / Removed / Updated [X].

Updated boilerplate template path identification in Windows.

Migration Guide

brikis98 commented 3 months ago

This is the announcement blog post I was talking about: https://blog.gruntwork.io/introducing-boilerplate-6d796444ecf6. It contains links to the boilerplate repo, but I made the links go to a specific commit, so if you make changes to the example code, it shouldn't break anything. We really do need the dynamic name in the test file (hence the {{ xxx }} in the path), but fixing all the issues on Windows is pretty important, so perhaps for now, you can update that example to dynamically generate the file, so we can get this merged soon, and we can come back to a more long-term fix in the future?

denis256 commented 3 months ago

Fixed tests for Windows and updated approach with variables in file names - in git are stored "generic" names and in tests for "unix" platform files are renamed with variables in the name

https://github.com/gruntwork-io/boilerplate/pull/164/files#diff-029441898e3ff4247efb42bd1056bce6b2b51b6a8950731f9b94c71ff93ae364R78