gruntwork-io / cloud-nuke

A tool for cleaning up your cloud accounts by nuking (deleting) all resources within it
https://gruntwork.io/
MIT License
2.81k stars 358 forks source link

feature: added support for china region #766

Closed james03160927 closed 2 months ago

james03160927 commented 3 months ago

Description

Fixes https://github.com/gruntwork-io/cloud-nuke/issues/126

TODOs

Read the Gruntwork contribution guidelines.

Release Notes (draft)

Added / Removed / Updated [X].

Migration Guide

denis256 commented 2 months ago

Looks like changes are failing to compile

# github.com/gruntwork-io/cloud-nuke/aws/resources
aws/resources/ec2_placement_group.go:32:16: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)
aws/resources/ec2_placement_group_types.go:41:19: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)
wakeful commented 2 months ago

Rebasing should fix the problem

$ go build .
# github.com/gruntwork-io/cloud-nuke/aws/resources
aws/resources/ec2_placement_group.go:32:16: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)
aws/resources/ec2_placement_group_types.go:41:19: configObj.EC2PlacementGroups undefined (type config.Config has no field or method EC2PlacementGroups)

$ git log feature/support-china-regions..master --oneline
4d997c4 (upstream/master, origin/master, origin/HEAD, master) fix: iam user exclude not working (#764)
0c6e8ba (tag: v0.37.2) add aws v2 sdk to support newer resources (#745) (#746)
45e4ac8 Fix config rule nuking (#762)
9f56e5a fix: nuke failure when route53 record NS exists with subdomain (#759)
c818032 Fix merge conflict issue (#761)

$ git rebase master
Successfully rebased and updated refs/heads/feature/support-china-regions.

$ go build .

$ echo $?
0
james03160927 commented 2 months ago

Rebased again. Should be good now.