Perform direct asset name comparison

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

587 stars 90 forks source link

Perform direct asset name comparison #102

Closed tonerdo closed 2 years ago

tonerdo commented 2 years ago

Description

Handle situations where the release asset name contains regex symbols that could mess up matching.

Documentation

TODOs

Please ensure all of these TODOs are completed before asking for a review.

[x] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
[x] Update the docs.
[x] Keep the changes backward compatible where possible.
[x] Run the pre-commit checks successfully.
[x] Run the relevant tests successfully.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.

Related Issues

Fixes #93

rhoboat commented 2 years ago

I kicked off the build and it passed on CI!

tonerdo commented 2 years ago

@brikis98 is there a repo where it'll be okay to upload multiple release assets to help with testing? I don't want to pollute any of our actual repos.

rhoboat commented 2 years ago

It would make sense to use these: https://github.com/gruntwork-io/fetch-test-public https://github.com/gruntwork-io/fetch-test-private

Do you have access to these @tonerdo ? (credit to @yorinasub17)

tonerdo commented 2 years ago

@rhoboat I don't have access to create new releases on https://github.com/gruntwork-io/fetch-test-public. I don't have access to https://github.com/gruntwork-io/fetch-test-private at all

tonerdo commented 2 years ago

@brikis98 I was only able to add a test for an asset with the + sign. Good thing is that when I try to upload files containing other regex characters, GitHub simply converts them to ..