Add support for two digit versions - vX.Y

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

589 stars 90 forks source link

Add support for two digit versions - vX.Y #36

Closed tomdee closed 6 years ago

tomdee commented 6 years ago

The version parsing library already supports them, but it normalizes all version strings to have three components. This fix properly handles versions that have been normalized in that way.

Fixes #24

tomdee commented 6 years ago

@brikis98 I've addressed your comment and added some test cases. I've just amended my previous commit as this change is quite small, PTAL.

brikis98 commented 6 years ago

@josh-padnick Could you review?

tomdee commented 6 years ago

Test added, back to you.

brikis98 commented 6 years ago

I'll merge now and let the tests run. Once they pass, I'll issue a new release.

brikis98 commented 6 years ago

https://github.com/gruntwork-io/fetch/releases/tag/v0.3.1. Thx @tomdee!