search

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.
https://www.gruntwork.io/
MIT License
589 stars 90 forks source link

support github enterprise by allowing custom api and base urls #43

Closed jniesen closed 6 years ago

jniesen commented 6 years ago

Fetch seems like a much more enjoyable way to fetch release artifacts from GitHub on the command line. More enjoyable then writing a curl script and more reusable.

However, I'm working with repos in both GitHub Enterprise (GHE) and GitHub.com. These changes make it so that I can pass in the URLs (base and api) of the GHE instance that I'm working with and be able to fetch artifacts from there.

I did some basic smoke testing on this. I was able to fetch from GHE. I can add/fix tests if it's required for merge, it just won't be until tomorrow.

jniesen commented 6 years ago

@brikis98 I made the changes you suggested and updated the test suite. This is ready for review.

jniesen commented 6 years ago

Updated to address the things brought up in the last round of review. Thank you for adding me to the repo. I was able to get the complete test suite passing.

brikis98 commented 6 years ago

https://github.com/gruntwork-io/fetch/releases/tag/v0.3.0