Fetch version constraints tag does not support paging in tags list

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

589 stars 90 forks source link

Fetch version constraints tag does not support paging in tags list #46

Open yorinasub17 opened 5 years ago

yorinasub17 commented 5 years ago

If you are referencing a sufficiently old release tag in a version constraints tag, fetch will fail.

Example:

fetch --repo 'https://github.com/gruntwork-io/module-ecs' --tag '~>v0.3.2' foo

fails with:

ERROR: Error occurred while computing latest tag that satisfies version contraint expression: -1 - Tag does not exist

josh-padnick commented 5 years ago

Interesting, this definitely sounds like a bug. All the automated tests on this tool assume a small number of releases, so we didn't explicitly test against large numbers of releases. Perhaps when we fix this, for the failing test first, we can find an open source repo that has a large number of releases and triggers this bug.

brikis98 commented 5 years ago

Could this be a pagination issue? i.e., if there are lots of tags, we are only fetching the first page of results?

yorinasub17 commented 5 years ago

Yes. Sorry I should have mentioned that in the description, but added that to the title.