Check and report error on empty option values

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

589 stars 90 forks source link

Check and report error on empty option values #55

Closed vedala closed 5 years ago

vedala commented 5 years ago

Please review my PR with changes to fix issue #31.

The issue mentions that an incorrect error is reported on supplying empty value to option --branch. But the same issue can happen when an empty value is supplied to any of the other options. This PR fixes the issue for all options.

I modified the parseOptions() function to return an additional value for error. I felt this resulted in least complicated code.

vedala commented 5 years ago

It was a pleasure working on this PR, thanks for merging into master.

josh-padnick commented 5 years ago

New release issued! Binaries should be automatically added in a few mins. Thanks again!