Show file count on zip extraction

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

587 stars 90 forks source link

Show file count on zip extraction #76

Closed pete0emerson closed 3 years ago

pete0emerson commented 3 years ago

This closes #39

The route I took here was to just show the non-directory file count every time; if you'd prefer that I follow the letter of the issue and only print when the number of files is zero, I can make that change.

I also did a minor "look and feel" by pluralizing the wording, I think it's a nice touch, but it does add a bit of extra code (no ternary operator in golang), so I'm happy to change that if desired, too.

pete0emerson commented 3 years ago

I realized that I marked these issues as resolved when probably it's best for you to mark them as resolved once you agree that the issue is actually resolved! Not positive exactly which workflow you prefer.

brikis98 commented 3 years ago

Tests passed! Merging now.