search

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.
https://www.gruntwork.io/
MIT License
587 stars 90 forks source link

Certain repos fail silently #86

Closed ddnexus closed 2 years ago

ddnexus commented 3 years ago

Works with other repos but the following fails/freezes:

$ fetch --repo="https://github.com/Jannomag/Yaru-Colors" --ref="20.10.1" --source-path="/Themes" /tmp/yaru-themes
Downloading git reference "20.10.1" of https://github.com/Jannomag/Yaru-Colors ...

It fails also with --commit, --tag, --branch etc. Is there any way to debug what is happening?

brikis98 commented 3 years ago

Are you able to git clone that repo locally?

ddnexus commented 3 years ago

Yes of course. Did you try to clone it and to run the command? I suspect you would get to the same conclusion.

brikis98 commented 3 years ago

Ah, I didn't realize that was an open source repo I had access to! Most people use fetch with private repos.

I can indeed confirm the bug. Not sure of the cause, and am too buried at the moment to dig in. If anyone has time to look into this, PRs are welcome!

ddnexus commented 3 years ago

Is there any flag or any other way to get a debugging feedback from fetch?

brikis98 commented 3 years ago

No, not currently. Better logging is something we'd like to add.

raidancampbell commented 2 years ago

I'm unable to reproduce this, and several new tags were created shortly after this ticket was raised related to --ref. I suspect this isn't an issue anymore

tonerdo commented 2 years ago

@ddnexus I looked into reproducing this and was unable to. This seems have possibly been fixed by updates to fetch. Closing out this issue, feel free to reopen if you encounter it again.