Fetching asset files with + signs causes them not to be found.

gruntwork-io / fetch

Download files, folders, and release assets from a specific git commit, branch, or tag of public and private GitHub repos.

https://www.gruntwork.io/

MIT License

587 stars 90 forks source link

Fetching asset files with + signs causes them not to be found. #93

Closed easel closed 2 years ago

easel commented 3 years ago

For a repo+release that has a file named pipeline-assembly-0.1.0+1-6d47f7c7.jar, --release-asset=pipeline-assembly* works fine but --release-asset=pipeline-assembly-0.1.0+1-6d47f7c7.jar says Could not find assets matching pipeline-assembly-0.1.0+1-6d47f7c7.jar in release v0.1.0+1-6d47f7c7.

My assumption is there's some sort of url encoding issue going on with the "+" when querying the github api for the assets on the release.

brikis98 commented 3 years ago

Thanks for reporting. Does seem like a bug. I'm not sure when we'll be able to get to it, so if someone has a chance to take a look, a PR is very welcome!

tonerdo commented 2 years ago

I've been able to reproduce the problem. Looking into a fix