Closed nirnanaaa closed 2 years ago
Thanks so much for your contribution, @nirnanaaa! I'll take a look at this shortly.
The implementation mostly looks good to me! I added some code necessary for allowing the parsing of the new --base-branch-name
flag.
In local testing, I found one issue that I'll need to fix prior to us merging this in: namely the behavior where we key off an HTTP 422 status code from Github whenever a pull request fails to be opened.
Currently, we're using this return code to determine when someone has requested a draft pull request via the --draft
flag on a repo that does not support drafts. However, Github's API also returns a 429 when the base branch target is invalid - meaning the user specifies a base branch that does not exist.
Before we can merge this, I'll need to add logic to determine which type of HTTP 429 error we received: a) the error relating to draft pull requests or b) the error relating to the base branch name provided by the user being invalid.
The implementation mostly looks good to me! I added some code necessary for allowing the parsing of the new
--base-branch-name
flag.In local testing, I found one issue that I'll need to fix prior to us merging this in: namely the behavior where we key off an HTTP 422 status code from Github whenever a pull request fails to be opened.
Currently, we're using this return code to determine when someone has requested a draft pull request via the
--draft
flag on a repo that does not support drafts. However, Github's API also returns a 429 when the base branch target is invalid - meaning the user specifies a base branch that does not exist.Before we can merge this, I'll need to add logic to determine which type of HTTP 429 error we received: a) the error relating to draft pull requests or b) the error relating to the base branch name provided by the user being invalid.
Alright - did this in 1adbd58. Kicking off tests now and then will look for someone who's not me to review!
Thanks for the review! Going to merge this in now.
Support overriding base branch name (Follow up to https://github.com/gruntwork-io/git-xargs/issues/22)
Description
Since our git workflow uses multiple branches of the same repository in some places, I thought it would make sense to support an optional argument for overriding the base branch name globally (might be an addition to #22).
Documentation
--base-branch-name=<xxx>
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955
orbug/missing-count-param-434
.Related Issues
22