Improve ErrorWithExitCode

gruntwork-io / go-commons

A standard library to use in all Gruntwork CLI tools

https://www.gruntwork.io/

MIT License

35 stars 26 forks source link

Closed yorinasub17 closed 4 years ago

yorinasub17 commented 4 years ago

I noticed that the user experience for returning ErrorWithExitCode isn't quite great, so I made a few improvements here:

Support using both WithStackTrace and ErrorWithExitCode, so that you can get both a stack trace and exit with exit code.
Output the underlying error message instead of ErrorWithExitCode{ Err = Deployment failed, ExitCode = 1 }
Refactor checkForErrorsAndExit so we can test the exit code functionality without the test exiting due to the call to os.Exit.

yorinasub17 commented 4 years ago

I'm blocked on this in my other PR so going to go ahead and merge+release this, but feedback is still welcome.