search

gruntwork-io / go-commons

A standard library to use in all Gruntwork CLI tools
https://www.gruntwork.io/
MIT License
35 stars 26 forks source link

Consolidate multierror packages #34

Closed infraredgirl closed 3 years ago

infraredgirl commented 3 years ago

Currently we have several implementations of the multierror functionality spread out across different repos:

This is bad for many reasons not least of which being maintenance. Ideally we would avoid reinventing the wheel by using an existing open source implementation of the multierror concept, such as hashicorp/go-multierror. However, this is currently not an option due to the licensing limitations.

Therefore we have two options:

  1. If we conclude to allow MPL licences (see https://github.com/gruntwork-io/company/issues/48 for more context), we should get rid of all the above custom implementations of multierror and replace them with go-multierror.
  2. If the above is not possible, we should migrate the implementation of multierror to gruntwork-cli.
infraredgirl commented 3 years ago

Update: Since we've been cleared to use code licensed with MPL, we should proceed with option 1 above.

infraredgirl commented 3 years ago

I've opened relevant issues in corresponding repos:

Since no change will be done in this repo, I'm closing this issue.