Add version compatibility to the HPA API

gruntwork-io / helm-kubernetes-services

Helm charts that can be used to package your applications into production ready deployments for Kubernetes. https://www.gruntwork.io

Apache License 2.0

190 stars 152 forks source link

Add version compatibility to the HPA API #146

Closed paul-pop closed 1 year ago

paul-pop commented 1 year ago

Description

Fixes #145.

TODOs

Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Use autoscaling/v2 API for Kubernetes versions >= 1.23.

Migration Guide

paul-pop commented 1 year ago

@yorinasub17 👋

Any chance for a quick look and this a potential release so k8s 1.23 gets the support it needs?

paul-pop commented 1 year ago

@autero1 Can you please re-check? Hopefully this gives other contributors some examples on how to test capabilities and server versions during the render.

I've also fixed the pre-commit hook for helmlint and updated it to the latest version as the previous one was returning a warning:


➜  helm-kubernetes-services git:(fix/145/hpa-api-version-compatibility) pre-commit run --all-files                   
[WARNING] Unexpected key(s) present on https://github.com/gruntwork-io/pre-commit: sha
helmlint.................................................................Passed

autero1 commented 1 year ago

Hi, sorry for the delay. I've kicked off the tests again.

autero1 commented 1 year ago

All the tests failed on:

Running Go tests in  with command: go test -v -timeout 60m -parallel 128  -tags integration . -short
# sigs.k8s.io/json/internal/golang/encoding/json
../../.go_workspace/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1249:12: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
../../.go_workspace/pkg/mod/sigs.k8s.io/json@v0.0.0-20211020170558-c049b76a60c6/internal/golang/encoding/json/encode.go:1255:18: sf.IsExported undefined (type reflect.StructField has no field or method IsExported)
FAIL    github.com/gruntwork-io/helm-kubernetes-services/test [build failed]

paul-pop commented 1 year ago

Closing as #151 was merged with the changes.