171 inject Secret Store CSI driver `deployment_spec.tpl`

gruntwork-io / helm-kubernetes-services

Helm charts that can be used to package your applications into production ready deployments for Kubernetes. https://www.gruntwork.io

Apache License 2.0

190 stars 152 forks source link

171 inject Secret Store CSI driver `deployment_spec.tpl` #172

Closed omar-devolute closed 10 months ago

omar-devolute commented 11 months ago

Description

Fixes #171 . Can be considered part (subtask) of #118

In the deployment_spec.tpl we must allow a new "as" value to be passed to a secret block, we call this new type "csi".

Receiving this type of a secret, the tpl has to mix functionality of both volumes and environment types, as we will require a env block and a volumeMounts block

Steps

[x] add template test - to check a csi block is passed to the secret
[x] modify deployment_spec.tpl so that it can accept "csi" for the values of the "as" and test the template builds appropriately

Release Notes (draft)

TODOs

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Include release notes.

Release Notes

Allow secret of type csi, inject Secret Store CSI related fields to deployment spec Env and Volumes

ryehowell commented 11 months ago

Hi @omar-devolute, thanks for this contribution! I am going to add this to our project backlog so it gets into our queue for review.

nadiia-caspar commented 11 months ago

Hey @ryehowell any update for this? We are looking forward to using these changes in our infra!

ryehowell commented 11 months ago

Hi @nadiia-caspar, thanks for following up! I am hoping to get to this soon. We have it in the queue for review. Hoping to take a look by the end of the week. Thanks for your patience!

ryehowell commented 11 months ago

@nadiia-caspar @omar-devolute I just kicked off CI build. Will be reviewing this shortly.

ryehowell commented 11 months ago

Looks like there are some CI test failures. I think it is due to a small regression that is noted in the review.

nadiia-caspar commented 10 months ago

@ryehowell i have to take over this PR, could you please help me to complete it?

ryehowell commented 10 months ago

Hi @nadiia-caspar, how can I help? Is there something specific that you need assistance with?

nadiia-caspar commented 10 months ago

Hi @ryehowell i made some changes (not sure what helped exactly 😄) but the template tests are now successful. The integration tests we didn't add, the because it would require the installation of the Secret Store CSI driver Helm chart. So I guess now you can review the PR. Let me know if any changes are required

nadiia-caspar commented 10 months ago

@ryehowell do you know when the release with these changes will be available in the helm repo?

ryehowell commented 10 months ago

The latest version will be released at some point later today @nadiia-caspar and will be available in the Gruntwork Helm chart repo. I can send a message once the release has been completed and the latest version of the chart is available.

nadiia-caspar commented 10 months ago

@ryehowell thanks for the update, don't worry I will check the repo later today/tomorrow :)

ryehowell commented 10 months ago

Hi @nadiia-caspar, the latest version has been released and should be available within the next hour. Cheers!