search

gruntwork-io / helm-kubernetes-services

Helm charts that can be used to package your applications into production ready deployments for Kubernetes. https://www.gruntwork.io
Apache License 2.0
193 stars 156 forks source link

Deployment.spec.replicas incorrectly set when using HPA #180

Closed harrymilne closed 8 months ago

harrymilne commented 9 months ago

Describe the bug

When horizontalPodAutoscaler.enabled is set to true the Deployment spec.replicas value should not be set as it will cause the ReplicaSet to revert from whatever HPA is recommending.

To Reproduce

  1. set horizontalPodAutoscaler.enabled to true
  2. deploy new version
  3. watch as Pods match the spec.replicas rather than matching HPA

Expected behavior A new deployment matches the Pods recommended by HPA

ryehowell commented 8 months ago

Hi @harrymilne, just to close the loop on this, this issue was resolved and the fix is available in the latest release of the Helm chart v0.2.25. Thanks for reporting the issue and your patience on a fix!