Avoid setting replicase while HPA is enabled - Githubissues

gruntwork-io / helm-kubernetes-services

Helm charts that can be used to package your applications into production ready deployments for Kubernetes. https://www.gruntwork.io

Apache License 2.0

193 stars 156 forks source link

Avoid setting replicase while HPA is enabled #181

Closed mateimicu closed 8 months ago

mateimicu commented 8 months ago

Description

Setting a replica number if HPA is used can cause outages (if replicas is 0) or degraded performance if replicas < minReplicas

One thing to note: The canary deployment is not targeted by the HPA:

The name of the canary has -canary at the end see code
The HPA target focuses on the main deployment only see code

So we need to avoid the replicas only if the deployment is not a canary.

Fixes #180.

TODOs

Read the Gruntwork contribution guidelines.

~[] Update the docs.~
[ ] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X].

Ignore replicaCount when HPA is enabled to avoid drastic fluctuations during releases.

Migration Guide

-