Feature/issue 194 - Githubissues

gruntwork-io / kubergrunt

Kubergrunt is a standalone go binary with a collection of commands to fill in the gaps between Terraform, Helm, and Kubectl. https://www.gruntwork.io

Apache License 2.0

518 stars 88 forks source link

Feature/issue 194 #195

Closed pras111gw closed 1 year ago

pras111gw commented 1 year ago

Description

Fixes #194 .

TODOs

Read the Gruntwork contribution guidelines.

[x] Update the docs.
[x] Run the relevant tests successfully, including pre-commit checks.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
[x] Include release notes. If this PR is backward incompatible, include a migration guide.

Release Notes (draft)

Added / Removed / Updated [X]. Updated dependencies for following CVEs reported. https://security-tracker.debian.org/tracker/CVE-2022-1996 https://github.com/advisories/GHSA-cg3q-j54f-5p7p

Migration Guide

zackproser commented 1 year ago

Thanks @pras111gw - it looks like there may be at least one legitimate test failure here:

TestDeleteSecurityGroupDependencies/unattached-ni 2023-04-28T01:20:49Z logger.go:66: - Installing hashicorp/aws v4.65.0...
=== CONT  TestFindLatestEKSBuilds/eks/coredns-1.25
    sync_test.go:221: 
            Error Trace:    /home/circleci/project/eks/sync_test.go:221
            Error:          Not equal: 
                            expected: "1.9.3-eksbuild.2"
                            actual  : "1.9.3-eksbuild.3"

                            Diff:
                            --- Expected
                            +++ Actual
                            @@ -1 +1 @@
                            -1.9.3-eksbuild.2
                            +1.9.3-eksbuild.3
            Test:           TestFindLatestEKSBuilds/eks/coredns-1.25
--- FAIL: TestFindLatestEKSBuilds (0.00s)

pras111gw commented 1 year ago

Hi @zackproser Thanks. I updated the test and got it working in circleci.

zackproser commented 1 year ago

@pras111gw Nice, thank you :raised_hands: