gruntwork-io / kubergrunt

Kubergrunt is a standalone go binary with a collection of commands to fill in the gaps between Terraform, Helm, and Kubectl. https://www.gruntwork.io
Apache License 2.0
516 stars 87 forks source link

🐛 (eks sync-core-components): Increase maxEKSBuild #215

Closed ThisGuyCodes closed 10 months ago

ThisGuyCodes commented 10 months ago

Description

Fixes #214

The maximum number of builds (sub-patches?) to search for with eks compnent images was hard coded to 10 (actually 9, since the last one has to error / miss for the code to work), but there are in fact 10 builds of eks/coredns:1.9.3-eksbuild. This doubles the threshold to 20, to reduce the chances of this happening again.

At present any attempt to create / update an EKS cluster using K8s 1.26 will error (see #214).

$ curl https://602401143452.dkr.ecr.us-west-2.amazonaws.com/v2/eks/coredns/manifests/v1.9.3-eksbuild.10 -H "Authorization: Basic $token"
{
   "schemaVersion": 2,
   "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
   "manifests": [
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:ccd971aef1b9e189ec21a2e70ba93ed6a339ea8be071f28cff6833db833fd742",
         "platform": {
            "architecture": "amd64",
            "os": "linux"
         }
      },
      {
         "mediaType": "application/vnd.docker.distribution.manifest.v2+json",
         "size": 739,
         "digest": "sha256:00905877cf1be0c1440cde988319f5a6fff848dd783a4517db3c848fd7ef9c5c",
         "platform": {
            "architecture": "arm64",
            "os": "linux"
         }
      }
   ]
}

Release Notes

Increase maxEKSBuild to 20, Fixes #214

ThisGuyCodes commented 10 months ago

I feel #216 is a more permanent solution than this, and it makes performance more consistent across the board. But I acknowledge it's much more complex so I'll leave it to the maintainers to decide.

ryehowell commented 10 months ago

Hi @ThisGuyCodes , we are testing this PR now. Can you confirm what version of kubergrunt you are using just for an apples to apples comparison?

ThisGuyCodes commented 10 months ago

I'm using the latest release

ryehowell commented 10 months ago

I'm using the latest release

Ok perfect, thank you for confirming.

ryehowell commented 10 months ago

Hi @ThisGuyCodes, as mentioned in #216, this PR has been merged and released. v0.13.1 should address the issue with kubergrunt. Thanks again for your contribution!