Adds a new golangci-lint hook in the Gruntwork script style and marks golint as deprectated. Why?golint is frozen and deprecated. golangci-lint is quite popular and is capable of running multiple linting tools.
Minor
This PR also fixes the failing ci so the tests pass.
Documentation
Updated README.md to describe the new hook.
TODOs
Please ensure all of these TODOs are completed before asking for a review.
[x] Ensure the branch is named correctly with the issue number. e.g: feature/new-vpc-endpoints-955 or bug/missing-count-param-434.
[x] Update the docs.
[x] Keep the changes backward compatible where possible.
[x] Run the pre-commit checks successfully.
[x] Run the relevant tests successfully.
[x] Ensure any 3rd party code adheres with our license policy or delete this line if its not applicable.
robmorgan
commented
1 year ago
Description
Adds a new
golangci-linthook in the Gruntwork script style and marksgolintas deprectated. Why?golintis frozen and deprecated.golangci-lintis quite popular and is capable of running multiple linting tools.Minor
This PR also fixes the failing ci so the tests pass.
Documentation
Updated README.md to describe the new hook.
TODOs
Please ensure all of these TODOs are completed before asking for a review.
feature/new-vpc-endpoints-955orbug/missing-count-param-434.Related Issues
n/a