search

gruntwork-io / pre-commit

A collection of pre-commit hooks used by Gruntwork tools
https://gruntwork.io/
Apache License 2.0
484 stars 155 forks source link

Fix `tflint` deprecation warning - "tflint FILE/DIR" is deprecated #94

Closed lukasz-mitka closed 1 year ago

lukasz-mitka commented 1 year ago

Describe the solution you'd like I don't want to see these warnings

WARNING: "tflint FILE/DIR" is deprecated and will error in a future version. Use --chdir or --filter instead.

Describe alternatives you've considered Stop using gruntwork-io/pre-commit. Don't really want to go there. Downgrade tflint. Don't want to do that either.

Additional context tflint release notes on deprecation - https://github.com/terraform-linters/tflint/releases/tag/v0.46.0 Tested with gruntwork-io/pre-commit v0.1.19

gcagle3 commented 1 year ago

Hi @lukasz-mitka! With the merging of PR #92, new functionality was added that allows you to pass arguments directly to tflint. This was included in release v0.1.21. Can you take a look and see if this resolves the issue you're having, since it will allow you to pass --filter directly?

lukasz-mitka commented 1 year ago

@gcagle3 that could work, but I was hoping for out of the box solution.

gcagle3 commented 1 year ago

@lukasz-mitka that makes sense, thank you. We'll work to get PR #95 updated with the changes from #92 so we can add this functionality.

gcagle3 commented 1 year ago

This has been merged and is now available in release v0.1.22.