Standardizing dependencies to a list input

gruntwork-io / terraform-google-sql

Terraform modules for deploying Google Cloud SQL (e.g. MySQL, PostgreSQL) in GCP

https://gruntwork.io

Apache License 2.0

92 stars 103 forks source link

Standardizing dependencies to a list input #32

Closed autero1 closed 5 years ago

autero1 commented 5 years ago

As discussed in https://github.com/gruntwork-io/terraform-kubernetes-helm/pull/25, this PR used a list variable dependencies to implement module dependencies.

rileykarson commented 5 years ago

I think Yori changed to using wait_for, we should make sure the inputs / outputs end up the same. https://github.com/gruntwork-io/terraform-kubernetes-helm/pull/25/files#diff-be81a9776cb0172380d889233e68ad18R23

yorinasub17 commented 5 years ago

Ah! The perils of distributed team! Sorry I felt that wait_for was actually a good name to use.

That said, I do not feel strongly about the name. Both are good to me. Given that, let's use dependencies and what is here in the interest of avoiding another cycle. This is nice, because then my change in the other PR will be backwards compatible.

All that to say, @autero1 don't change your implementation!