search

gruntwork-io / terraform-google-sql

Terraform modules for deploying Google Cloud SQL (e.g. MySQL, PostgreSQL) in GCP
https://gruntwork.io
Apache License 2.0
92 stars 103 forks source link

Add point in time recovery option in backend configuration #50

Closed mvoitko closed 3 years ago

robmorgan commented 3 years ago

Hey @mvoitko,

Thanks for your contribution. How did you test this?

mvoitko commented 3 years ago

hey @robmorgan/ I have tested the fix by deploying postgresql db with my fix. When I have done the same without my fix, the option is ignored.

robmorgan commented 3 years ago

@mvoitko ok LGTM. I've kicked off the tests in: https://app.circleci.com/pipelines/github/gruntwork-io/terraform-google-sql/91/workflows/6b513bf2-0130-44e9-8ba4-2778b7655466

robmorgan commented 3 years ago

Note: This might need the updated Google provider in https://github.com/gruntwork-io/terraform-google-sql/pull/51 to work correctly.

mvoitko commented 3 years ago

@robmorgan thanks. Will fix the tests to pass on CircleCI and update providers

mvoitko commented 3 years ago

@robmorgan Hi, I have updated the PR and rebased the latest master. Could you please review and trigger tests on CI?

robmorgan commented 3 years ago

Hi @mvoitko, I'm happy to test your PR, but just scanning the code quickly, it seems you will need to swap your condition statement around. See https://github.com/gruntwork-io/terraform-google-sql/pull/50/files#diff-ae9c8fa94b8488ac9aa4da95f1c19d805e75292969cc372d0925f10e0532640aR79 - I believe this logic would apply to MySQL instead of Postgres.

mvoitko commented 3 years ago

@robmorgan fixed

robmorgan commented 3 years ago

@mvoitko thanks, I plan to release this on Friday.

robmorgan commented 3 years ago

Released in https://github.com/gruntwork-io/terraform-google-sql/releases/tag/v0.3.1