search

gruntwork-io / terraform-google-sql

Terraform modules for deploying Google Cloud SQL (e.g. MySQL, PostgreSQL) in GCP
https://gruntwork.io
Apache License 2.0
92 stars 103 forks source link

Update repo to work with Terraform 0.13.x #51

Closed robmorgan closed 3 years ago

robmorgan commented 3 years ago
  1. Update CircleCI to use Terraform 0.13.x.
  2. Upgraded the Google Providers to 3.43.0.
  3. Dropped GAE configuration options.
  4. Update the version constraint on all examples to require at least 0.12.26.
  5. Update pre-commit hooks to add gofmt.
  6. Upgrade the tests to support Terratest v0.30.23

In general, TF 0.13.x seems backwards compatible from a testing perspective: I did not need to change anything in modules in this PR.

robmorgan commented 3 years ago

Builds are currently failing.

robmorgan commented 3 years ago

Tests passed in https://app.circleci.com/pipelines/github/gruntwork-io/terraform-google-sql/93/workflows/3c5acbbd-765b-4a27-b9c4-3057e920c6eb/jobs/191

robmorgan commented 3 years ago

@brikis98 thanks for the review. I'll release next week!